Sloppy language #224

2019-03-02T15:53:48Z

dianawi commented

2019-03-02 15:53:48 +00:00

(Migrated from github.com)

No description provided.

matthijskooijman (Migrated from github.com) requested changes

2019-03-11 20:06:27 +00:00

matthijskooijman (Migrated from github.com) left a comment

Most of these changes look good. I added some inline comments. Also, login-username, login-password and add-mailing are introduced as strings in the first commit, but only used in the second commit. It would be better to group both adding and using these strings in a single commit (ideally in a separate commit from the other string changes, but putting everything in a single commit would also be ok for me, since it all improves or adds translations).

Most of these changes look good. I added some inline comments. Also, `login-username`, `login-password` and `add-mailing` are introduced as strings in the first commit, but only used in the second commit. It would be better to group both adding and using these strings in a single commit (ideally in a separate commit from the other string changes, but putting everything in a single commit would also be ok for me, since it all improves or adds translations).

system/languages/en.php

I can't find any reference to this string in the code?

system/languages/nl.php

					
				@ -15,3 +15,3 @@

						"logout" => "uitloggen",

						"quit" => "stop",

						"quit" => "stoppen",

						"logged-in-as" => "ingelogd als",