Comment unanonymous 2 #227

Merged

dianawi merged 1 commit from comment-unanonymous-2 into master

2019-04-09 08:45:35 +00:00

dianawi commented

2019-03-09 14:32:23 +00:00

(Migrated from github.com)

No description provided.

matthijskooijman (Migrated from github.com) requested changes

2019-03-11 20:33:21 +00:00

matthijskooijman (Migrated from github.com) left a comment

I think the last two commits could be squashed together into one?

Also, what is the problem this PR is trying to solve? Are people forgetting to add their name? Isn't the name field mandatory? Or are people using aliases and we want to encourage them to use their real name?

I think the last two commits could be squashed together into one? Also, what is the problem this PR is trying to solve? Are people forgetting to add their name? Isn't the name field mandatory? Or are people using aliases and we want to encourage them to use their real name?

system/datatypes/peer_reviewed_article.php

Why break the EOF-block here? AFAICS this change is not needed?

I wonder if this unanonymous remark should be in the <label> tag, or perhaps outside of it? I wonder if it is conceptually part of the label or not? Or should this perhaps be an info-icon?

I wonder if this unanonymous remark should be in the `<label>` tag, or perhaps outside of it? I wonder if it is conceptually part of the label or not? Or should this perhaps be an info-icon?

system/languages/en.php

This commit only seems to add this string, but never uses it?

laurensmartina commented

2019-03-30 12:05:59 +00:00

(Migrated from github.com)

Fixed all, please review again.

matthijskooijman (Migrated from github.com) approved these changes

2019-04-08 21:06:42 +00:00

matthijskooijman (Migrated from github.com) left a comment

I'm still not sure what problem we're trying to solve, and I'm not entirely sure if art-comment-unanonymous is the most clear string identifier here, but the code itself looks good, so I'm ok with merging this as-is (after testing).

I'm still not sure what problem we're trying to solve, and I'm not entirely sure if `art-comment-unanonymous` is the most clear string identifier here, but the code itself looks good, so I'm ok with merging this as-is (after testing).

matthijskooijman commented

2019-04-09 08:45:10 +00:00

(Migrated from github.com)

Works, rebased and merging.

No reviewers

matthijskooijman

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

harmen/hypha!227

No description provided.

Rows
Columns