Adds an explanation to the quit page #218

Merged
laurensmartina merged 2 commits from improve-quit-texts into master 2019-04-25 09:31:37 +00:00
laurensmartina commented 2019-02-23 15:11:04 +00:00 (Migrated from github.com)

At the quit page, it was unclear what the user could expect.
This fixes that problem.

At the quit page, it was unclear what the user could expect. This fixes that problem.
matthijskooijman (Migrated from github.com) reviewed 2019-02-23 15:11:04 +00:00
dianawi (Migrated from github.com) reviewed 2019-02-23 15:11:04 +00:00
giplt (Migrated from github.com) reviewed 2019-02-23 15:11:04 +00:00
tammoterhark (Migrated from github.com) reviewed 2019-02-23 15:11:04 +00:00
matthijskooijman commented 2019-02-23 16:01:30 +00:00 (Migrated from github.com)

The commit also changes the button text, @laurensmartina, perhaps you could add that in the commit message?

@all, what do you think of this change/wording? Here's how it looks with this PR:

image
image
image
image

Personally, I wouldn't mind removing the "Screw you guys..." text, just leave the textbox empty by default?

The commit also changes the button text, @laurensmartina, perhaps you could add that in the commit message? @all, what do you think of this change/wording? Here's how it looks with this PR: ![image](https://user-images.githubusercontent.com/194491/53288737-7cc8e300-378c-11e9-89fb-21cacd8cf6c5.png) ![image](https://user-images.githubusercontent.com/194491/53288739-805c6a00-378c-11e9-8ff9-3e3588ac8f77.png) ![image](https://user-images.githubusercontent.com/194491/53288741-82bec400-378c-11e9-927c-ea967d910fdd.png) ![image](https://user-images.githubusercontent.com/194491/53288743-85b9b480-378c-11e9-84cf-d2c2a0ce8a49.png) Personally, I wouldn't mind removing the "Screw you guys..." text, just leave the textbox empty by default?
laurensmartina commented 2019-03-30 12:50:02 +00:00 (Migrated from github.com)

I think it's fine for now.. It can be further improved if needed.

I think it's fine for now.. It can be further improved if needed.
dianawi commented 2019-04-20 13:03:29 +00:00 (Migrated from github.com)

I think it is good, and yes, let's take out the screw you guys text.

I think it is good, and yes, let's take out the screw you guys text.
matthijskooijman commented 2019-04-25 09:31:29 +00:00 (Migrated from github.com)

I've removed the "Screw you..." wording, and rebased. Ready to merge now.

I've removed the "Screw you..." wording, and rebased. Ready to merge now.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
harmen/hypha!218
No description provided.