6 Home
Matthijs Kooijman edited this page 2018-09-05 15:14:38 +02:00

Code of conduct

  • all changes will be pull requests in their own branches
  • as pull requests come in, team members are asked for reviewing these (with ..some.. speed)
  • minor/trivial changes can be pushed directly to master
  • master branche should always be stable
  • all commits in master branche (also: after merge) should be usable (= not break system)
  • work in small chunks of work (separate bug fixes from new developments, so they can be merged sooner)
  • commits should encompass only one "thing"
  • completed pull requests should be merged normally, not rebased to keep a link to the pull request.
  • branches used to create pull requests can (and should) use history rewriting, so be careful when pulling from such branches
  • when receiving feedback on pull requests, it is preferred to make improvements using history rewriting (where appropriate), rather than just adding new fixing commits