Convert festival to new datatype style #337

Merged

matthijskooijman merged 14 commits from festival-newstyle into master

2020-08-24 13:09:39 +00:00

matthijskooijman commented

2020-08-19 10:52:57 +00:00

(Migrated from github.com)

This improves the code style of the festival, as we previously did for other datatypes.

This PR starts with a few small refactorings that were easy to separate, and ends with one quite huge commit that applies a lot of changes to the festival module. These could maybe have been separated, but given the size of this refactor, this does not warrant the enormous amount of extra time that would have needed.

There are still some things that are imperfect (e.g. translation strings that get variables appended rather than interpolated), but these can better be fixed later than further enlarging this PR.

This improves the code style of the festival, as we previously did for other datatypes. This PR starts with a few small refactorings that were easy to separate, and ends with one quite huge commit that applies a lot of changes to the festival module. These could maybe have been separated, but given the size of this refactor, this does not warrant the enormous amount of extra time that would have needed. There are still some things that are imperfect (e.g. translation strings that get variables appended rather than interpolated), but these can better be fixed later than further enlarging this PR.

laurensmartina (Migrated from github.com) approved these changes

2020-08-24 13:00:29 +00:00

matthijskooijman commented

2020-08-24 13:09:34 +00:00

(Migrated from github.com)

I squashed the fixup commits, should be ready to merge now.