peer_reviewed_article: Pass single HyphaDomElement to addDiscussion #319

Merged

matthijskooijman merged 1 commit from Issue/318-Cannot-resolve-own-blocks into master

2020-05-19 19:39:33 +00:00

matthijskooijman commented

2020-05-19 08:36:46 +00:00

(Migrated from github.com)

Previously, this would pass a NodeList containing (normally) just a
single element. However, a NodeList does not seem to have a nodeName
property, which addDiscussion used to differentiate between review and
public comments.

This caused addDiscussion treat review discussions as public
discussions, leaving out the user attribute. This in turn prevented
users from resolving their own blocking comments, since there was no
longer a record of the initiator of a discussion (#318).

Passing a single HyphaDomElement rather than a NodeList to
addDiscussion() makes the latter work as expected again.

This fixes #318.

Previously, this would pass a NodeList containing (normally) just a single element. However, a NodeList does not seem to have a `nodeName` property, which `addDiscussion` used to differentiate between review and public comments. This caused `addDiscussion` treat review discussions as public discussions, leaving out the `user` attribute. This in turn prevented users from resolving their own blocking comments, since there was no longer a record of the initiator of a discussion (#318). Passing a single HyphaDomElement rather than a NodeList to `addDiscussion()` makes the latter work as expected again. This fixes #318.

laurensmartina (Migrated from github.com) approved these changes

2020-05-19 18:38:31 +00:00

No reviewers

laurensmartina

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

harmen/hypha!319

No description provided.

Rows
Columns