Adds CSS class to index item indicating public or private state

laurensmartina commented

2019-12-29 23:18:07 +00:00

(Migrated from github.com)

In order to be more flexible in the way the index items can be styled a
CSS class, indicating the public of private state, is added.

In order to be more flexible in the way the index items can be styled a CSS class, indicating the public of private state, is added.

tammoterhark commented

2019-12-30 07:08:32 +00:00

(Migrated from github.com)

I very much like this, but it is not a way for getting rid of the asterisk, which was ment to indicate that a page was not published yet. So I would also like a class indicating the status of the content type. This could be a class that is shown only when the page is not published yet, like .is_not_published

laurensmartina commented

2019-12-30 18:53:34 +00:00

(Migrated from github.com)

I very much like this, but it is not a way for getting rid of the asterisk, which was ment to indicate that a page was not published yet.

Unfortunately I don't understand what you mean. Do you want to keep the asterisk?

So I would also like a class indicating the status of the content type. This could be a class that is shown only when the page is not published yet, like .is_not_published

You can accomplish the same with 'is-public' and 'is-private' as you could with 'is_not_published'. Furthermore more consistent to indicate what something is in stead of indication what something is not.

> I very much like this, but it is not a way for getting rid of the asterisk, which was ment to indicate that a page was not published yet. Unfortunately I don't understand what you mean. Do you want to keep the asterisk? > So I would also like a class indicating the status of the content type. This could be a class that is shown only when the page is not published yet, like .is_not_published You can accomplish the same with 'is-public' and 'is-private' as you could with 'is_not_published'. Furthermore more consistent to indicate what something is in stead of indication what something is not.

giplt commented

2019-12-30 19:01:48 +00:00

(Migrated from github.com)

Just to be clear, an asterisk doesn't indicate 'not yet published page' but 'private page' as opposed to 'public page'. Recent focus on peer reviewed article content (De Stadsbron) may suggest that the end state of each and any page should be public. However, hypha should facilitate sharing of information within a project group just as well as updating the rest of the world about it. So maybe the difference between the state of a page (private/public) and the state of an article (draft/review/approved/published) is a little confusing here?

tammoterhark commented

2019-12-30 19:18:31 +00:00

(Migrated from github.com)

I guess so.

If what Harmen wrote is true, he mostly is, than I withdraw my comment and
I approve of this PR.

On Mon, 30 Dec 2019, 20:01 Harmen G. Zijp, notifications@github.com wrote:

Just to be clear, an asterisk doesn't indicate 'not yet published page'
but 'private page' as opposed to 'public page'. Recent focus on peer
reviewed article content (De Stadsbron) may suggest that the end state of
each and any page should be public. However, hypha should facilitate
sharing of information within a project group just as well as updating the
rest of the world about it. So maybe the difference between the state of a
page (private/public) and the state of an article
(draft/review/approved/published) is a little confusing here?

—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/PlanBCode/hypha/pull/282?email_source=notifications&email_token=ABRO25JGOAQGQHVRMBTA6M3Q3JAR3A5CNFSM4KBEGOWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH263FY#issuecomment-569765271,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABRO25PQTSIE6VWIILCFUQLQ3JAR3ANCNFSM4KBEGOWA
.

I guess so. If what Harmen wrote is true, he mostly is, than I withdraw my comment and I approve of this PR. On Mon, 30 Dec 2019, 20:01 Harmen G. Zijp, <notifications@github.com> wrote: > Just to be clear, an asterisk doesn't indicate 'not yet published page' > but 'private page' as opposed to 'public page'. Recent focus on peer > reviewed article content (De Stadsbron) may suggest that the end state of > each and any page should be public. However, hypha should facilitate > sharing of information within a project group just as well as updating the > rest of the world about it. So maybe the difference between the state of a > page (private/public) and the state of an article > (draft/review/approved/published) is a little confusing here? > > — > You are receiving this because your review was requested. > Reply to this email directly, view it on GitHub > <https://github.com/PlanBCode/hypha/pull/282?email_source=notifications&email_token=ABRO25JGOAQGQHVRMBTA6M3Q3JAR3A5CNFSM4KBEGOWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH263FY#issuecomment-569765271>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABRO25PQTSIE6VWIILCFUQLQ3JAR3ANCNFSM4KBEGOWA> > . >

tammoterhark commented

2020-01-05 09:09:04 +00:00

(Migrated from github.com)

yes, but: so what?

An asterisk is a solution, could also be another color of the text, another
font(-weight/-size) etc. These decisions are up to the designer.

Op za 4 jan. 2020 om 19:19 schreef Matthijs Kooijman <
notifications@github.com>:

@matthijskooijman requested changes on this pull request.

Looks good to me. However, this change now removes the asterisk from the
HTML, which I think should be replaced with an asterisk using a
content:before or similar in the CSS? That would make this a refactor,
rather than a change in behaviour.

—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/PlanBCode/hypha/pull/282?email_source=notifications&email_token=ABRO25JXA4HVXDOFN4FWDPDQ4DHL3A5CNFSM4KBEGOWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQVQNGA#pullrequestreview-338364056,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABRO25NS2THEFBVJZZHHTGTQ4DHL3ANCNFSM4KBEGOWA
.

yes, but: so what? An asterisk is a solution, could also be another color of the text, another font(-weight/-size) etc. These decisions are up to the designer. Op za 4 jan. 2020 om 19:19 schreef Matthijs Kooijman < notifications@github.com>: > *@matthijskooijman* requested changes on this pull request. > > Looks good to me. However, this change now removes the asterisk from the > HTML, which I think should be replaced with an asterisk using a > content:before or similar in the CSS? That would make this a refactor, > rather than a change in behaviour. > > — > You are receiving this because your review was requested. > Reply to this email directly, view it on GitHub > <https://github.com/PlanBCode/hypha/pull/282?email_source=notifications&email_token=ABRO25JXA4HVXDOFN4FWDPDQ4DHL3A5CNFSM4KBEGOWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCQVQNGA#pullrequestreview-338364056>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABRO25NS2THEFBVJZZHHTGTQ4DHL3ANCNFSM4KBEGOWA> > . >

matthijskooijman commented

2020-01-05 11:36:37 +00:00

(Migrated from github.com)

An asterisk is a solution, could also be another color of the text, another
font(-weight/-size) etc. These decisions are up to the designer.

Yes, but the default theme should also be usable, so that should somehow indicate private pages as before. Lacking an incentive to change things, I would suggest preserving the asterisk (but through CSS so it can be customized). If we also want to change the default design, that's also fine by me, but then we should pick something else. If we want to change the default design to not show private pages anymore, then that's also fine, as long as it is an explicit choice (which should then be documented in the commit message at least). I have no real preference here.

> An asterisk is a solution, could also be another color of the text, another font(-weight/-size) etc. These decisions are up to the designer. Yes, but the default theme should also be usable, so that should somehow indicate private pages as before. Lacking an incentive to change things, I would suggest preserving the asterisk (but through CSS so it can be customized). If we *also* want to change the default design, that's also fine by me, but then we should pick something else. If we want to change the default design to *not* show private pages anymore, then that's also fine, as long as it is an explicit choice (which should then be documented in the commit message at least). I have no real preference here.

laurensmartina commented

2020-01-06 10:13:14 +00:00

(Migrated from github.com)

An asterisk is a solution, could also be another color of the text, another
font(-weight/-size) etc. These decisions are up to the designer.

Yes, but the default theme should also be usable, so that should somehow indicate private pages as before. Lacking an incentive to change things, I would suggest preserving the asterisk (but through CSS so it can be customized). If we also want to change the default design, that's also fine by me, but then we should pick something else. If we want to change the default design to not show private pages anymore, then that's also fine, as long as it is an explicit choice (which should then be documented in the commit message at least). I have no real preference here.

Fixed!

> > An asterisk is a solution, could also be another color of the text, another > > font(-weight/-size) etc. These decisions are up to the designer. > > Yes, but the default theme should also be usable, so that should somehow indicate private pages as before. Lacking an incentive to change things, I would suggest preserving the asterisk (but through CSS so it can be customized). If we _also_ want to change the default design, that's also fine by me, but then we should pick something else. If we want to change the default design to _not_ show private pages anymore, then that's also fine, as long as it is an explicit choice (which should then be documented in the commit message at least). I have no real preference here. Fixed!

Rows
Columns

Adds CSS class to index item indicating public or private state #282