Adds a help icon with rules for civil discussion in comments #243

Merged

dianawi merged 2 commits from rules-for-comments into master

2019-04-25 08:40:43 +00:00

dianawi commented

2019-04-20 14:56:45 +00:00

(Migrated from github.com)

No description provided.

laurensmartina (Migrated from github.com) reviewed

2019-04-20 14:56:45 +00:00

matthijskooijman (Migrated from github.com) approved these changes

2019-04-25 08:19:04 +00:00

matthijskooijman (Migrated from github.com) left a comment

Looks good. One comment inline, which I'll fix in a minute.

system/datatypes/peer_reviewed_article.php

I think this if block should be smaller, so there is less duplication of (HTML) code. Probably setting $infoCommentRule to the empty string for logged in users is sufficient here.

I think this if block should be smaller, so there is less duplication of (HTML) code. Probably setting `$infoCommentRule` to the empty string for logged in users is sufficient here.

matthijskooijman commented

2019-04-25 08:40:27 +00:00

(Migrated from github.com)

I made the proposed change. I also moved the info icon into the label tag, so it is shown on the same line as the 'comment on this articlelabel rather than on a line by itself. I added one more commit to remove a
` element and I rebased on latest master. Ready to merge now.

I made the proposed change. I also moved the info icon into the label tag, so it is shown on the same line as the 'comment on this article` label rather than on a line by itself. I added one more commit to remove a `<br/>` element and I rebased on latest master. Ready to merge now.

No reviewers

laurensmartina

matthijskooijman

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

harmen/hypha!243

No description provided.

Rows
Columns