Different labels for new discussions and replies #228

2019-03-09T14:40:04Z

dianawi commented

2019-03-09 14:40:04 +00:00

(Migrated from github.com)

…comments.
Also fine with me to stick with the other version.

…comments. Also fine with me to stick with the other version.

tammoterhark (Migrated from github.com) reviewed

2019-03-30 10:32:50 +00:00

system/datatypes/peer_reviewed_article.php

					
				@ -1157,17 +1157,17 @@ EOF;

					 * @return string

Please leave away the rows and columns and the <strong> in these statements, beter to instead give the fields a descriptive class, so styling can be adapted via hypha.css.

Alternative:
<label for="$commentFieldName" class="comment-field-name-label"> $react </label><textarea name="$commentFieldName" id="$commentFieldName" class="comment-field-name"></textarea>

Please leave away the `rows` and `columns` and the `<strong>` in these statements, beter to instead give the fields a descriptive class, so styling can be adapted via hypha.css. Alternative: `<label for="$commentFieldName" class="comment-field-name-label"> $react </label><textarea name="$commentFieldName" id="$commentFieldName" class="comment-field-name"></textarea>`

matthijskooijman (Migrated from github.com) reviewed

2019-04-09 10:19:45 +00:00

system/datatypes/peer_reviewed_article.php

					
				@ -1157,17 +1157,17 @@ EOF;

					 * @return string

This is the subject of #217 and fixed by #219. I think it is out of scope for this PR, so I'm resolving this conversation.

matthijskooijman commented

2019-04-25 09:09:01 +00:00

(Migrated from github.com)

I've rebased this PR, removed some code duplication and renamed the strings to art-comment-on-article and art-comment-on-comment to make it a bit clearer where they are used. I've also changed "Join the discussion" to "Join this discussion", the make it more clear that there are different discussions and you're replying to a particular one. With that, I think this is ready to merge.

I've rebased this PR, removed some code duplication and renamed the strings to `art-comment-on-article` and `art-comment-on-comment` to make it a bit clearer where they are used. I've also changed "Join the discussion" to "Join this discussion", the make it more clear that there are different discussions and you're replying to a particular one. With that, I think this is ready to merge.

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

harmen/hypha!228

Rows
Columns