Remove cols and rows attributes from comment textareas #219

Merged

matthijskooijman merged 1 commit from remove-cols-rows into master

2019-04-25 08:49:45 +00:00

matthijskooijman commented

2019-02-23 16:40:38 +00:00

(Migrated from github.com)

This fixes #217

matthijskooijman commented

2019-02-23 16:42:10 +00:00

(Migrated from github.com)

@tammo, this removes the cols and rows attributes as suggested in #217. Could you have a look at adding the proper CSS to make the textareas look ok again in the default CSS?

Also, there are some more textareas with rows and cols in the settings page. I was planning to also remove these here, but I think there are not sufficient CSS classes there to be able to style them properly, so I left them out for now.

@tammo, this removes the cols and rows attributes as suggested in #217. Could you have a look at adding the proper CSS to make the textareas look ok again in the default CSS? Also, there are some more textareas with rows and cols in the settings page. I was planning to also remove these here, but I think there are not sufficient CSS classes there to be able to style them properly, so I left them out for now.

tammoterhark (Migrated from github.com) reviewed

2019-04-09 08:38:46 +00:00

system/datatypes/peer_reviewed_article.php

The id that is produced here cannot be handled with css.

What is produced:

<strong><label for="discussion_comment/new_public"> reageer op het artikel </label></strong><textarea name="discussion_comment/new_public" id="discussion_comment/new_public"></textarea>

In my opinion the class="discussion_comment new_public" would be better, since the slash produces an error in my css editor.

The id that is produced here cannot be handled with css. What is produced: `<strong><label for="discussion_comment/new_public"> reageer op het artikel </label></strong><textarea name="discussion_comment/new_public" id="discussion_comment/new_public"></textarea>` In my opinion the class="discussion_comment new_public" would be better, since the slash produces an error in my css editor.

tammoterhark (Migrated from github.com) reviewed

2019-04-09 11:04:58 +00:00

system/datatypes/peer_reviewed_article.php

Decided to delete the ID, since it was not needed.

matthijskooijman commented

2019-04-09 18:22:03 +00:00

(Migrated from github.com)

I squashed the CSS changes into the first commit (so it now removes rows/cols and replaces that with CSS in one go).

I had another look at the second commit removing the ID tag, but it seems it is required after all. Not for CSS matching, but to match the label's for attribute. As for the contents of the id attribute, according to Mozilla whitespace is disallowed, but (in HTML5 at least) anything else is ok. So I think the current code is actually fine?

I would propose dropping the second commit and merging the first (after one more test).

I squashed the CSS changes into the first commit (so it now removes rows/cols and replaces that with CSS in one go). I had another look at the second commit removing the ID tag, but it seems it is required after all. Not for CSS matching, but to match the `label`'s `for` attribute. As for the contents of the id attribute, according to [Mozilla](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/id) whitespace is disallowed, but (in HTML5 at least) anything else is ok. So I think the current code is actually fine? I would propose dropping the second commit and merging the first (after one more test).

matthijskooijman commented

2019-04-25 08:49:39 +00:00

(Migrated from github.com)

I rebased, dropped the second commit (which removed the id attribute), so this can be merged.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

harmen/hypha!219

No description provided.

Rows
Columns