harmen/mapmind
1
0
Fork 0
Code Issues 13 Pull requests Projects Releases Packages Wiki Activity

Bugfixes #1

Merged
pierstitus merged 4 commits from bugfixes into master 2021-02-12 09:28:01 +00:00
Conversation 6 Commits 4 Files changed 3 +10 -10
pierstitus commented 2021-02-10 10:25:07 +00:00 (Migrated from github.com)
Copy link

fix source and sink images, make it work on nginx and make country links work on other domains

fix source and sink images, make it work on nginx and make country links work on other domains
giplt (Migrated from github.com) requested changes 2021-02-11 22:50:35 +00:00
giplt (Migrated from github.com) left a comment
Copy link

I believe changing the name for the map manipulation flag shouldn't be in this commit, although I am open to renaming the "ahn" prefix throughout the code that still refers to the Dutch elevation data specifically...

I believe changing the name for the map manipulation flag shouldn't be in this commit, although I am open to renaming the "ahn" prefix throughout the code that still refers to the Dutch elevation data specifically...
giplt (Migrated from github.com) approved these changes 2021-02-11 22:50:57 +00:00
giplt (Migrated from github.com) approved these changes 2021-02-11 22:53:50 +00:00
giplt (Migrated from github.com) approved these changes 2021-02-11 22:55:28 +00:00
pierstitus commented 2021-02-12 08:19:28 +00:00 (Migrated from github.com)
Copy link

the gManipulate variable was named ahnManipulate everywhere else, so probably it was an accidental typo in an earlier change. Changing it to dtmManipulate or so makes sense though.

the gManipulate variable was named ahnManipulate everywhere else, so probably it was an accidental typo in an earlier change. Changing it to dtmManipulate or so makes sense though.
giplt commented 2021-02-12 09:26:41 +00:00 (Migrated from github.com)
Copy link

Shoot, I misread and thought proposed change was from ahn to g prefix.

Shoot, I misread and thought proposed change was from ahn to g prefix.
Sign in to join this conversation.
Reviewers
No reviewers
giplt
Labels
Clear labels   
bug

Something isn't working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
harmen/mapmind!1
No description provided.