Installing from git shows only the English language #94

Closed
opened 2018-10-25 12:41:38 +00:00 by matthijskooijman · 0 comments
matthijskooijman commented 2018-10-25 12:41:38 +00:00 (Migrated from github.com)

When running the hypha.php installer, a list of languages is presented to the user to select the default language. This language list is based on the languages.php file contained inside hypha.php. When running from a downloaded bundle, this file is complete. However, when running from git, the file is already on the filesystem, and there is only a dummy version inside hypha.php, to at least not break things.

Ideally, this would simply read the file from the filesystem when it is not present inside hypha.php, rather than needing a dummy file, so the complete list of languages is always available. When both versions are available, I think the one from hypha.php should take precedence, to allow overwriting an existing install.

When running the hypha.php installer, a list of languages is presented to the user to select the default language. This language list is based on the `languages.php` file contained *inside* `hypha.php`. When running from a downloaded bundle, this file is complete. However, when running from git, the file is already on the filesystem, and there is only a [dummy version](https://github.com/PlanBCode/hypha/blob/124a05cb7ab1756c128c52edb5a11803588b223b/hypha.php#L501) inside hypha.php, to at least not break things. Ideally, this would simply read the file from the filesystem when it is not present inside `hypha.php`, rather than needing a dummy file, so the complete list of languages is always available. When both versions are available, I think the one from `hypha.php` should take precedence, to allow overwriting an existing install.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
harmen/hypha#94
No description provided.