Refactor to use multiple <form> tags #359
Labels
No labels
Component: User interface
Component: Wymeditor
Help wanted
Level: Difficult
Level: Easy
Level: Moderate
Pagetype: Festival
Pagetype: Mailinglist
Pagetype: Peer reviewed article
Pagetype: Text
Privacy GDPR AVG
status: has conflicts
Status: Needs changes
Status: Needs discussion
Status: Needs review
Status: Ready to merge
Status: Waiting for response
Type: Bug
Type: Enhancement
Type: Question
Usecase: De Stadsbron
Usecase: Koppelting
Usecase: MeetjeStad
Value: Coders
Value: Security
Value: Users
Value: Visitors
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
harmen/hypha#359
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Currently, there is only one
<form>tag in the entire page that is shared by all forms, which is not always ideal (i.e. in peer_reviewed_article, this requires adding a suffix to field names since all comment forms are submitted at the same time).In #135, some changes were made to prepare for having multiple form tags (i.e. form submissions now explicitly reference their containing form and an explicit "default form" is tracked on HyphaHtmlDocument). This should be completed at some point.
A related improvement would be to turn submit buttons into normal submit buttons, rather than doing all form submits through the javascript
hypha()function. This makes things simpler, and allows the browser to apply any validation (i.e. fromrequiredortype=emailattributes on input fields, which are currently ignored, presumably because javascript forces form submission).