Issue/66 paste from word #314

2020-05-15T07:17:04Z

RoukePouw commented

2020-05-15 07:17:04 +00:00

(Migrated from github.com)

No description provided.

tammoterhark (Migrated from github.com) reviewed

2020-05-15 07:17:04 +00:00

matthijskooijman (Migrated from github.com) reviewed

2020-05-15 08:38:11 +00:00

matthijskooijman (Migrated from github.com) left a comment

Well, that looks simple enough. I left some inline remarks, and also some caveats in #66.

system/core/editor.php

					
				@ -153,1 +159,4 @@

				                // initiate the "image_upload" plugin

								wym.image_upload();

There's again whitespace issues here (you're inserting spaces, while it should be tabs).

What editor are you using? We could maybe add a .editorconfig file to the project if your editor supports that (though I'm not sure if the indentation style is sufficiently consistent throughout the project...).

There's again whitespace issues here (you're inserting spaces, while it should be tabs). What editor are you using? We could maybe add a `.editorconfig` file to the project if your editor supports that (though I'm not sure if the indentation style is sufficiently consistent throughout the project...).

system/core/editor.php

I actually suspect this textarea can be removed and you can just do wym.paste(pasteContent). It looks like the getData('text') will already give the plaintext version of the clipboard contents, so going through the textarea.value does not do anything special (that's just a string variable essentially).

I actually suspect this textarea can be removed and you can just do `wym.paste(pasteContent)`. It looks like the `getData('text')` will already give the plaintext version of the clipboard contents, so going through the `textarea.value` does not do anything special (that's just a string variable essentially).

RoukePouw (Migrated from github.com) reviewed

2020-05-15 08:41:44 +00:00

system/core/editor.php

I suspect it as well, but couldn't test it so tried to replicate it as faithfully as possible for now.

matthijskooijman (Migrated from github.com) reviewed

2020-05-15 09:01:25 +00:00

system/core/editor.php

I'm pretty sure that if it works for any other formatted text (e.g. from libreoffice, or a browser), it will work from Word too. The existing "Paste from Word" is actually not really Word-specific, it's just named that way because that's where the biggest junk comes from, I guess.

laurensmartina (Migrated from github.com) reviewed

2020-10-04 16:44:11 +00:00

system/core/editor.php

					
				@ -153,1 +159,4 @@

				                // initiate the "image_upload" plugin

								wym.image_upload();

fixed

laurensmartina (Migrated from github.com) reviewed

2020-10-04 17:01:27 +00:00

system/core/editor.php

fixed

matthijskooijman commented

2020-10-06 12:57:59 +00:00

(Migrated from github.com)

This is superseded by #345, so I'm closing this one.

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

No reviewers

tammoterhark

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

harmen/hypha!314

Rows
Columns