harmen/hypha

Further textpage improvements #272

Merged

matthijskooijman merged 11 commits from textpage-improvements into master

2019-11-20 07:05:28 +00:00

matthijskooijman commented

2019-11-18 17:00:42 +00:00

(Migrated from github.com)

This PR does some more work on the textpage coding style for #135.

This PR does some more work on the textpage coding style for #135.

laurensmartina (Migrated from github.com) requested changes

2019-11-18 18:21:17 +00:00

system/datatypes/text.php

Please remove extra new line.

Please remove extra new line.

Comment are written in lower case throughout the application.

Comment are written in lower case throughout the application.

system/datatypes/text.php

					
				@ -182,0 +199,4 @@

							$commands = $this->html->find('#pageCommands');

							$commands->append($this->makeActionButton(__('cancel')));

							$commands->append($this->makeActionButton(__('save'), self::PATH_TRANSLATE, self::CMD_TRANSLATE));

Comment are written in lower case throughout the application.

Comment are written in lower case throughout the application.

matthijskooijman (Migrated from github.com) reviewed

2019-11-19 12:12:43 +00:00

system/datatypes/text.php

Heh, never really consciously realized that, but indeed. Fixed now.

Heh, never really consciously realized that, but indeed. Fixed now.

matthijskooijman commented

2019-11-19 12:14:03 +00:00

(Migrated from github.com)

Thanks for the review, I have fixed your comments. Ok to merge like this?

Thanks for the review, I have fixed your comments. Ok to merge like this?

laurensmartina commented

2019-11-20 00:17:38 +00:00

(Migrated from github.com)

Trying to approve, but am unable to find the approve button.

Trying to approve, but am unable to find the approve button.

laurensmartina (Migrated from github.com) approved these changes

2019-11-20 00:18:55 +00:00

matthijskooijman commented

2019-11-20 07:05:36 +00:00

(Migrated from github.com)

Rebased and merged. Thanks for the review!

Rebased and merged. Thanks for the review!

Sign in to join this conversation.

No reviewers

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

harmen/hypha!272

No description provided.