harmen/hypha

Fork 0

Further improve theming support #175

New issue

Open

opened 2019-01-05 11:43:43 +00:00 by matthijskooijman · 5 comments

matthijskooijman commented

2019-01-05 11:43:43 +00:00

(Migrated from github.com)

#162 adds initial support for multiple themes, but is still rough. Further improvements are:

Allow creating themes through the webinterface
Move the default theme out of the data directory and make it un-editable (this fixes, or at least works towards, #93).
Merge the styles, themes and markup settings pages into one (this might be combined with #49).
Allow previewing a theme for the current session only, to allow changing a theme without all visitors seeing the work-in-progress.

#162 adds initial support for multiple themes, but is still rough. Further improvements are: - [x] Allow creating themes through the webinterface - [ ] Move the default theme out of the data directory and make it un-editable (this fixes, or at least works towards, #93). - [ ] Merge the styles, themes and markup settings pages into one (this might be combined with #49). - [x] Allow previewing a theme for the current session only, to allow changing a theme without all visitors seeing the work-in-progress.

matthijskooijman commented

2019-01-05 13:13:07 +00:00

(Migrated from github.com)

One thing to keep in mind is that the current default theme consists of multiple CSS file, of which only hypha.css can be edited. This might be something for #49 more than this issue, perhaps.

laurensmartina commented

2019-01-19 11:00:12 +00:00

(Migrated from github.com)

#162 adds initial support for multiple themes, but is still rough. Further improvements are:

Move the default theme out of the data directory and make it un-editable (this fixes, or at least works towards, #93).

Regarding the scope of this issue, I've decided to keep the default theme where it is. If it's needed to move the default theme, this can be done in the scope of an other issue.

> #162 adds initial support for multiple themes, but is still rough. Further improvements are: > > * [ ] Move the default theme out of the data directory and make it un-editable (this fixes, or at least works towards, #93). Regarding the scope of this issue, I've decided to keep the default theme where it is. If it's needed to move the default theme, this can be done in the scope of an other issue.

laurensmartina commented

2019-01-21 20:41:31 +00:00

(Migrated from github.com)

#162 adds initial support for multiple themes, but is still rough. Further improvements are:

Merge the styles, themes and markup settings pages into one (this might be combined with #49).

I'm not really sure how to combine these issues and I think they conflict somehow. And since there is already an issue for this, I'm also going to leave this out of the scope for this one. (also already talked with @tammoterhark about this)

> #162 adds initial support for multiple themes, but is still rough. Further improvements are: > > * [ ] Merge the styles, themes and markup settings pages into one (this might be combined with #49). I'm not really sure how to combine these issues and I think they conflict somehow. And since there is already an issue for this, I'm also going to leave this out of the scope for this one. (also already talked with @tammoterhark about this)

laurensmartina commented

2019-01-21 21:47:02 +00:00

(Migrated from github.com)

#162 adds initial support for multiple themes, but is still rough. Further improvements are:

Allow previewing a theme for the current session only, to allow changing a theme without all visitors seeing the work-in-progress.

I've created the option to preview a theme, but how the UI should look is not really clear to me. @tammoterhark do you have any suggestions?

> #162 adds initial support for multiple themes, but is still rough. Further improvements are: > > * [ ] Allow previewing a theme for the current session only, to allow changing a theme without all visitors seeing the work-in-progress. I've created the option to preview a theme, but how the UI should look is not really clear to me. @tammoterhark do you have any suggestions?

matthijskooijman commented

2019-01-21 22:03:47 +00:00

(Migrated from github.com)

I've created the option to preview a theme, but how the UI should look is not really clear to me. @tammoterhark do you have any suggestions?

My idea was to let a user select a theme that will be applied to the entire site, for that user (and perhaps that session) only. So in a way it would not really be a preview, but just an alternative theme selection. Not sure if per user or per session would be the best approach here.

> I've created the option to preview a theme, but how the UI should look is not really clear to me. @tammoterhark do you have any suggestions? My idea was to let a user select a theme that will be applied to the entire site, for that user (and perhaps that session) only. So in a way it would not really be a preview, but just an alternative theme selection. Not sure if per user or per session would be the best approach here.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

harmen/hypha#175

No description provided.

Rows
Columns