harmen/app-o-matic
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Basic example inconsistencies #1

New issue
Open
opened 2025-12-02 15:22:40 +00:00 by matthijs · 1 comment
matthijs commented 2025-12-02 15:22:40 +00:00
Copy link

I did a quick test of this first version, and it works well. Looking at the 1.basic example, I do see some small issues:

  1. The manifest.json references some icons that do not exist. Even more, the entire icons attribute does not seem used, and looking more closely, it seems that manifest.json might not be used at all?
  2. The menu always shows a login item, even when no login is defined (i.e. no login() function is defined).
  3. Typo in en.json: "url-copied": "A link to this view has been cpoied to the clipboard"
  4. Should en.json be split into a framework version with the strings used by the framework and an app version with strings added by the specific app?
I did a quick test of this first version, and it works well. Looking at the 1.basic example, I do see some small issues: 1. The `manifest.json` references some icons that do not exist. Even more, the entire `icons` attribute does not seem used, and looking more closely, it seems that `manifest.json` might not be used at all? 2. The menu always shows a login item, even when no login is defined (i.e. no `login()` function is defined). 3. Typo in `en.json`: `"url-copied": "A link to this view has been cpoied to the clipboard"` 4. Should `en.json` be split into a framework version with the strings used by the framework and an app version with strings added by the specific app?
harmen commented 2025-12-04 11:38:45 +00:00
Owner
Copy link
  1. The manifest.json is needed to package the webapp as a native smartphone app.
  2. Login functionality makes sense only when an authentication server is available, changed this so login item will be shown only when urlAPI is defined in config.json
  3. Fixed
  4. Could be done, but for now the added value doesn't offset the added complexity AFAIC.
1. The ```manifest.json``` is needed to package the webapp as a native smartphone app. 2. Login functionality makes sense only when an authentication server is available, changed this so login item will be shown only when urlAPI is defined in ```config.json``` 3. Fixed 4. Could be done, but for now the added value doesn't offset the added complexity AFAIC.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
harmen/app-o-matic#1
No description provided.